Dmp 5282 database data type consistency check #3095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karen-hedges
requested review from
DavidTMann,
cakeben and
jackmaloney
and removed request for
a team
karen-hedges
force-pushed
the
DMP-5282-DatabaseDataTypeConsistencyCheck
branch
3 times, most recently
from
6c96b91 to
dbcf502
Compare
Fixed bug that was introduced when certain ids where converted to bigints in the db but where they were used as foreign keys in other tables, they were still integers, which caused a mismatch between longs in java and integers in the DB
Fixed bug that was introduced when certain ids where converted to bigints in the db but where they were used as foreign keys in other tables, they were still integers, which caused a mismatch between longs in java and integers in the DB
Fixed bug that was introduced when certain ids where converted to bigints in the db but where they were used as foreign keys in other tables, they were still integers, which caused a mismatch between longs in java and integers in the DB
Fixed bug that was introduced when certain ids where converted to bigints in the db but where they were used as foreign keys in other tables, they were still integers, which caused a mismatch between longs in java and integers in the DB
Fixed bug that was introduced when certain ids where converted to bigints in the db but where they were used as foreign keys in other tables, they were still integers, which caused a mismatch between longs in java and integers in the DB
Added new index
karen-hedges
force-pushed
the
DMP-5282-DatabaseDataTypeConsistencyCheck
branch
from
78afa46 to
24a5ebc
Compare
hmcts-jenkins-cnp
bot
added
ns:darts-modernisation
prd:darts
rel:darts-api-pr-3095
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/DMP-5282
Change description
Fixed bug that was introduced when certain ids where converted to bigints in the db but where they were used as foreign keys in other tables, they were still integers, which caused a mismatch between longs in java and integers in the DB
Does this PR introduce a breaking change? (check one with "x")